Add Mooncake frule and rrule implementations#36
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #36 +/- ##
==========================================
+ Coverage 89.23% 93.07% +3.84%
==========================================
Files 8 11 +3
Lines 325 491 +166
==========================================
+ Hits 290 457 +167
+ Misses 35 34 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Oh god, this is going to be a compat nightmare |
Member
Author
|
I'm sorry 😭 |
Member
Author
|
Although is anyone using 1.6 anymore? We could just drop it in CI, the |
Jutho
reviewed
May 20, 2026
Jutho
reviewed
May 20, 2026
Jutho
approved these changes
May 20, 2026
Member
Jutho
left a comment
Jutho
left a comment
There was a problem hiding this comment.
Two suggestions but otherwise approved.
Co-authored-by: Jutho <Jutho@users.noreply.github.com>
Member
Author
|
Shouldn't we also take 1.6 out of CI, then? |
Member
Fine by me. |
added 2 commits
May 20, 2026 16:25
lkdvos
reviewed
May 20, 2026
lkdvos
approved these changes
May 20, 2026
lkdvos
changed the title
frule and rrule implementations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moving these over here to be more generic in response to comments on QuantumKitHub/TensorKit.jl#436